Single site with multiple domain names #37

New issue

Open

opened 2015-02-26 03:18:40 +00:00 by MrXavierLin · 2 comments

MrXavierLin commented

2015-02-26 03:18:40 +00:00

(Migrated from github.com)

I got error message like "Plugin settings are not yet saved for the site, please save settings!" in my nginx logs.

My site has multiple domain name, and is using domain-based template switcher. However, FFPC seems to save only one domain name in the global options array when settings is saved.

So next time when the other domain name reaches, $this->global_saved variable will be false and causing error messages.

Can you please add an option in the settings to let user enter multiple domain names(separated by comma, etc), and save the global option array with multiple domain names as keys?

I got error message like "Plugin settings are not yet saved for the site, please save settings!" in my nginx logs. My site has multiple domain name, and is using domain-based template switcher. However, FFPC seems to save only one domain name in the global options array when settings is saved. So next time when the other domain name reaches, $this->global_saved variable will be false and causing error messages. Can you please add an option in the settings to let user enter multiple domain names(separated by comma, etc), and save the global option array with multiple domain names as keys?

petermolnar commented

2015-02-26 08:07:13 +00:00

(Migrated from github.com)

hi,

unfortunately, with the current plugin, I can not do this. You could however enable wp-network and set the plugin network-wise; that way it will be applied on all subdomains.

Péter Molnár

hello@petermolnar.eu
+447592011721
https://petermolnar.eu

On 26 February 2015 04:18:41 CET, MrXavierLin notifications@github.com wrote:

I got error message like "Plugin settings are not yet saved for the
site, please save settings!" in my nginx logs.

My site has multiple domain name, and is using domain-based template
switcher. However, FFPC seems to save only one domain name in the
global options array when settings is saved.

So next time when the other domain name reaches, $this->global_saved
variable will be false and causing error messages.

Can you please add an option in the settings to let user enter multiple
domain names(separated by comma, etc), and save the global option array
with multiple domain names as keys?

Reply to this email directly or view it on GitHub:
https://github.com/petermolnar/wp-ffpc/issues/37

hi, ## unfortunately, with the current plugin, I can not do this. You could however enable wp-network and set the plugin network-wise; that way it will be applied on all subdomains. Péter Molnár hello@petermolnar.eu +447592011721 https://petermolnar.eu On 26 February 2015 04:18:41 CET, MrXavierLin notifications@github.com wrote: > I got error message like "Plugin settings are not yet saved for the > site, please save settings!" in my nginx logs. > > My site has multiple domain name, and is using domain-based template > switcher. However, FFPC seems to save only one domain name in the > global options array when settings is saved. > > So next time when the other domain name reaches, $this->global_saved > variable will be false and causing error messages. > > Can you please add an option in the settings to let user enter multiple > domain names(separated by comma, etc), and save the global option array > with multiple domain names as keys? > > --- > > Reply to this email directly or view it on GitHub: > https://github.com/petermolnar/wp-ffpc/issues/37

MrXavierLin commented

2015-02-27 03:08:46 +00:00

(Migrated from github.com)

err...I see. But enabling wp-network seems too aggressive to me. Could you introduce some callbacks in the code where global options is loaded / saved? Then I can take use of these callbacks in my own plugin to alter the global options. I think it makes sense because other plugins may need to disable certain type of cache, callbacks will make it easy for other plugins to corporate with FFPC.