ffpc v1.10.1 catastrophic fail with PHP < 5.5 and/or Wordpress 3.0 #60

New issue

Open

opened 2016-08-23 13:44:49 +01:00 by diablodale · 1 comment

diablodale commented

2016-08-23 13:44:49 +01:00

(Migrated from github.com)

While testing fixes for the filesystem usage in ffpc, I determined ffpc v1.10.1 is not compatible with PHP versions less than 5.5. It is also not compatible with Wordpress 3.0.

The fail is catastrophic. The plugin code will not activate or load in any way. The fail on PHP < 5.5 is in ...redis.php line 149. There is no "finally" clause in any version of PHP less than 5.5.

The catastrophic fail on Wordpress 3.0 is in ...backend.php line 356. There is no get_current_blog_id() function on Wordpress versions less than 3.1.

These catastrophic failures suggest the plugin has not been tested against Wordpress 3.0 or PHP < 5.5 since the above two code blocks were added. Perhaps wp-ffpc was tested when it was first released, but later code changes (like these) were made to the plugin and version testing was not undertaken.

There is no workaround other than updating
a) the plugin code
b) updating PHP and/or Wordpress
c) update the PHP and Wordpress version minimum requirements

For now, I have made code changes to v1.10.1 to resolve the above two catastrophic issues. The plugin will now load, however, there are a number of other UI bugs which are exposed.

While testing fixes for the filesystem usage in ffpc, I determined ffpc v1.10.1 is not compatible with PHP versions less than 5.5. It is also not compatible with Wordpress 3.0. The fail is catastrophic. The plugin code will not activate or load in any way. The fail on PHP < 5.5 is in ...redis.php line 149. There is no "finally" clause in any version of PHP less than 5.5. The catastrophic fail on Wordpress 3.0 is in ...backend.php line 356. There is no get_current_blog_id() function on Wordpress versions less than 3.1. These catastrophic failures suggest the plugin has not been tested against Wordpress 3.0 or PHP < 5.5 since the above two code blocks were added. Perhaps wp-ffpc was tested when it was first released, but later code changes (like these) were made to the plugin and version testing was not undertaken. There is no workaround other than updating a) the plugin code b) updating PHP and/or Wordpress c) update the PHP and Wordpress version minimum requirements For now, I have made code changes to v1.10.1 to resolve the above two catastrophic issues. The plugin will now load, however, there are a number of other UI bugs which are exposed.

diablodale commented

2016-08-23 13:46:35 +01:00

(Migrated from github.com)

Fixes for the two catastrophic bugs are in c5d6027761
This commit also includes fixes for jQuery tabs which would fail on earlier versions of Wordpress/jQuery

Fixes for the two catastrophic bugs are in https://github.com/diablodale/wp-ffpc/commit/c5d60277616c1a04c9e85650635989f277a47555 This commit also includes fixes for jQuery tabs which would fail on earlier versions of Wordpress/jQuery