petermolnar/wp-ffpc
1
0
Fork 0
Code Issues 22 Pull requests 4 Projects Releases Packages Wiki Activity Actions

Fix authentication autofilling wordpress username/password #52

Open
khromov wants to merge 1 commit from khromov/fix-password-autofill into master
pull from: khromov/fix-password-autofill
merge into: petermolnar:master
Conversation 2 Commits 1 Files changed 1 +1 -1
khromov commented 2016-05-24 20:36:20 +01:00 (Migrated from github.com)
Copy link

Fixes autofilling of the saved WordPress username/password.

It seems like the autofilling uses some (not so) smart heuristics - even changing the id and name of the form elements is not enough, simply having two input fields next to each other where one of them is type="password" is enough to trigger the autocomplete.

This PR changes the password field to a regular textfield - this has only cosmetical and no security implications since the password is sent along to the browser anyway. However the added cosmetical "niceness" does not make up for having to clear the field every time you want to save the settings. :)

Fixes autofilling of the saved WordPress username/password. It seems like the autofilling uses some (not so) smart heuristics - even changing the `id` and `name` of the form elements is not enough, simply having two input fields next to each other where one of them is `type="password"` is enough to trigger the autocomplete. This PR changes the password field to a regular textfield - this has only cosmetical and no security implications since the password is sent along to the browser anyway. However the added cosmetical "niceness" does not make up for having to clear the field every time you want to save the settings. :)
khromov commented 2016-08-08 16:44:31 +01:00 (Migrated from github.com)
Copy link

Bump!

Bump!
khromov commented 2016-09-29 22:16:34 +01:00 (Migrated from github.com)
Copy link

@petermolnar Could you please take a look at this? I'm open to any feedback you have and would love to see this merged!

@petermolnar Could you please take a look at this? I'm open to any feedback you have and would love to see this merged!
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin khromov/fix-password-autofill:khromov/fix-password-autofill
git checkout khromov/fix-password-autofill

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git checkout master
git merge --no-ff khromov/fix-password-autofill
git checkout khromov/fix-password-autofill
git rebase master
git checkout master
git merge --ff-only khromov/fix-password-autofill
git checkout khromov/fix-password-autofill
git rebase master
git checkout master
git merge --no-ff khromov/fix-password-autofill
git checkout master
git merge --squash khromov/fix-password-autofill
git checkout master
git merge --ff-only khromov/fix-password-autofill
git checkout master
git merge khromov/fix-password-autofill
git push origin master
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
invalid

   
question

   
wontfix
No labels
bug
duplicate
enhancement
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: petermolnar/wp-ffpc#52
No description provided.
Delete branch "khromov/fix-password-autofill"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?